Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glint --build --clean (broken since Volar) #768

Open
machty opened this issue Sep 25, 2024 · 0 comments
Open

Fix glint --build --clean (broken since Volar) #768

machty opened this issue Sep 25, 2024 · 0 comments

Comments

@machty
Copy link
Contributor

machty commented Sep 25, 2024

Fix glint --build --clean specs (broken since Volar -- cleans everything but .gts file outputs). Johnson thinks it can be supported, needs upstream fix.

Discord Thread

Reproduction

  1. Clone glint repo
  2. Run yarn / tsc commands
  3. cd test-packages/ts-template-imports-app
  4. run ../../packages/core/bin/glint.js --declaration --emitDeclarationOnly

The following files will show up:

        src/Greeting.gts.d.ts
        src/Greeting.gts.d.ts.map
        src/GreetingUntyped.gjs.d.ts
        src/GreetingUntyped.gjs.d.ts.map
        src/NoTemplate.gts.d.ts
        src/NoTemplate.gts.d.ts.map
        src/Playground.gts.d.ts
        src/Playground.gts.d.ts.map
        src/index.gts.d.ts
        src/index.gts.d.ts.map
        src/normal.d.ts
        src/normal.d.ts.map
        src/other.d.ts
        src/other.d.ts.map
  1. Attempt to clean these files: ../../packages/core/bin/glint.js --build --clean

All output files from a source .ts file are cleaned up, and the .map files for .gts source files are cleaned up, but .gts.d.ts files remain:

    src/Greeting.gts.d.ts
    src/GreetingUntyped.gjs.d.ts
    src/NoTemplate.gts.d.ts
    src/Playground.gts.d.ts
    src/index.gts.d.ts

These should be removed too.

Need to discuss with Johnson the current state/expectations for how to handle this. Also curious why Vue doesn't run into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant