You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! In the addRandomNode routine of today's mainline branch, line 50 of manyBodySampled.js, a value called a distance is calculated not by summing the squared dimension-wise differences, but by subtracting. The resulting value is compared against a distance calculated conventionally on line 29, by summing the squared differences.
This appears to be a bug that would cause the randomly selected new neighbor to replace an element of the current list more often than the algorithm and the code comments suggest it should. In that case, the fix is the one-character change shown below.
Hi! In the
addRandomNode
routine of today's mainline branch, line 50 ofmanyBodySampled.js
, a value called a distance is calculated not by summing the squared dimension-wise differences, but by subtracting. The resulting value is compared against a distance calculated conventionally on line 29, by summing the squared differences.This appears to be a bug that would cause the randomly selected new neighbor to replace an element of the current list more often than the algorithm and the code comments suggest it should. In that case, the fix is the one-character change shown below.
Should I make a pull request?
The text was updated successfully, but these errors were encountered: