Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treq.collect should treat returned Deferreds as applying backpressure #238

Open
graingert opened this issue Apr 11, 2019 · 2 comments
Open

treq.collect should treat returned Deferreds as applying backpressure #238

graingert opened this issue Apr 11, 2019 · 2 comments
Labels
enhancement

Comments

@graingert
Copy link
Member

by calling pauseProducing() and resumeProducing() correctly
graingert added a commit to graingert/treq that referenced this issue Apr 11, 2019
@graingert
add flow_collect, a version of collect that respects flow control Fixes
48d306a 
twisted#238
graingert added a commit to graingert/treq that referenced this issue Apr 11, 2019
@graingert
add flow_collect, a version of collect that respects flow control Fixes
0a2724a 
twisted#238
@glyph
Copy link
Member

glyph commented May 8, 2019

By "correctly" I think you mean "in response to a Deferred being returned by the callable"?

@graingert
Copy link
Member Author

graingert commented May 8, 2019 via email

@glyph glyph changed the title treq.collect should respect flow control treq.collect should treat returned Deferreds as applying backpressure May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@twm @graingert @glyph