Add deprecation message for ExtensionInterface::getLastModified() met…

…hod not implemented
twigphp · Dec 24, 2024 · 3a94244 · 3a94244
1 parent 95c05cd
commit 3a94244
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/src/ExtensionSet.php b/src/ExtensionSet.php
@@ -119,11 +119,16 @@ public function getLastModified(): int
         $lastModified = 0;
         foreach ($this->extensions as $extension) {
             $r = new \ReflectionObject($extension);
-            $lastModified = max(match(true) {
-                $r->hasMethod('getLastModified') => $extension->getLastModified(),
-                is_file($r->getFileName()) => filemtime($r->getFileName()),
-                default => 0,
-            }, $lastModified);
+
+            if ($r->hasMethod('getLastModified')) {
+                $lastModified = max($extension->getLastModified(), $lastModified);
+            } else {
+                trigger_deprecation('twig/twig', '3.18', 'Not implementing "%s::getLastModified()" in "%s" is deprecated.', ExtensionInterface::class, $extension::class);
+
+                if (is_file($r->getFileName())) {
+                    $lastModified = max(filemtime($r->getFileName()), $lastModified);
+                }
+            }
         }
 
         return $this->lastModified = $lastModified;

diff --git a/tests/CustomExtensionTest.php b/tests/CustomExtensionTest.php
@@ -78,4 +78,9 @@ public function getOperators(): array
     {
         return $this->operators;
     }
+
+    public function getLastModified(): int
+    {
+        return 0;
+    }
 }
diff --git a/tests/EnvironmentTest.php b/tests/EnvironmentTest.php
@@ -322,7 +322,7 @@ public function testAddExtension()
 
     public function testAddMockExtension()
     {
-        $extension = $this->createMock(ExtensionInterface::class);
+        $extension = $this->createMock(AbstractExtension::class);
         $loader = new ArrayLoader(['page' => 'hey']);
 
         $twig = new Environment($loader);