Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Allow .btn on [role="button"],[role="link"] with tabindex which ≠ -1 #347

Open
cvrebert opened this issue Jan 16, 2016 · 4 comments
Open

Comments

@cvrebert
Copy link
Collaborator

Refs #313.

@patrickhlauke
Copy link
Member

conceivably, tabindex could also be any valid number >= 0 (but not tabindex="-1") ... not sure that can be fully expressed with CSS selectors though, so perhaps just [tabindex] (knowing that it "may" catch some invalid combos) would be sufficient...

other edge case could be something that acts as a link, but wants to be visually styled as a button (like a call to action that actually opens a new page)...this would have a role="link" (and JS which when ENTER is pressed would the window's location...again, lots of faffing)

@patrickhlauke
Copy link
Member

i do wonder if at these stages (where authors explicitly do some very intensive work to use a <span> or similar rather than just a <button> or <a href...>), they may also understand the limitations of the linter...but hey it wouldn't harm either way, as we're just covering edge cases i guess

@cvrebert cvrebert changed the title Allow .btn on [role="button"][tabindex="0"] Allow .btn on [role="button"] with tabindex which ≠ -1 Jan 16, 2016
@cvrebert cvrebert changed the title Allow .btn on [role="button"] with tabindex which ≠ -1 Allow .btn on [role="button"],[role="link"] with tabindex which ≠ -1 Jan 16, 2016
@cvrebert
Copy link
Collaborator Author

not sure that can be fully expressed with CSS selectors though

No worries, we don't have that limitation. We try to express the constraints using selectors where possible, but we're okay with dropping down to JS when necessary.

@patrickhlauke
Copy link
Member

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants