Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LOINC #565

Open
aneiderhiser opened this issue Aug 7, 2024 · 7 comments
Open

Update LOINC #565

aneiderhiser opened this issue Aug 7, 2024 · 7 comments

Comments

@aneiderhiser
Copy link
Contributor

A new version of LOINC was just released on 8/6/2024 and we need to upgrade the version in Tuva.

@saywurdson
Copy link

Hi @aneiderhiser! I would like to work on this issue. This is my first time contributing and after reading through the contributing guidelines, i had a couple questions:

there were a few columns in the tuva seed files that don't have a corresponding column in the loinc files. is it ok to leave them blank?

For reference here are the columns:
terminology__loinc.csv: class_description, class_type_description
terminology__loinc_deprecated_mapping.csv: final_map_to, all_comments, depth

@aneiderhiser
Copy link
Contributor Author

@saywurdson yep i believe that is fine -- though @tuvaforrest can confirm. Also -- you won't be able to open a PR for this directly. We host the files on an AWS S3 bucket that is read-only to the public. Someone from the Tuva team will need to write the file. Post here when you have the files ready and we can coordinate hand-off.

@saywurdson
Copy link

Ok @aneiderhiser, once @tuvaforrest confirms, I have the files ready. I actually already created a PR. Should I just cancel it?

@aneiderhiser
Copy link
Contributor Author

@tuvaforrest or @cocozuloaga can you help here? ^^

@saywurdson
Copy link

Ok I went ahead and closed my PR. I also went ahead and attached the files to this message. Please let me know if there is anything else you need! Thanks
terminology__loinc_deprecated_mapping.csv
terminology__loinc.csv

@aneiderhiser
Copy link
Contributor Author

Thanks @saywurdson!

@saywurdson
Copy link

Sorry for the continued messages. I downloaded the old files from the website and compared with my updated loinc files. I was able to populated most of the fields that I had questions about and correct some things that I did wrong. Here are updated files for you. Thanks
terminology__loinc_deprecated_mapping.csv
terminology__loinc.csv

@aneiderhiser aneiderhiser moved this to Ready to Pull in The Tuva Project Backlog Nov 9, 2024
@aneiderhiser aneiderhiser moved this from Ready to Pull to 🏗 In Progress in The Tuva Project Backlog Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

3 participants