Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Vue's teleport #53

Open
kinow opened this issue Jun 8, 2023 · 2 comments
Open

Use Vue's teleport #53

kinow opened this issue Jun 8, 2023 · 2 comments
Assignees
Milestone

Comments

@kinow
Copy link
Member

kinow commented Jun 8, 2023

e.g.: cylc/cylc-ui#1318

@kinow kinow mentioned this issue Jan 12, 2024
7 tasks
@kinow kinow self-assigned this Jan 14, 2024
@kinow kinow modified the milestones: 1.3.0, 1.2.1 Jan 14, 2024
@kinow
Copy link
Member Author

kinow commented Jan 14, 2024

This probably cannot be implemented due to how we treat the children tabs/components (we do not have a fixed type, trying to be generic). To be reviewed and documented in a future release.

@kinow
Copy link
Member Author

kinow commented Jan 14, 2024

This library tries to add components as they are as Lumino tabs. This means without requiring any changes to the components, any props, nothing. It will use the .name to fetch the name of the component (which every Vue component should have, I believe), and then create a LuminoWidget and sync it programmatically to the DOM, instead of with Vue3 Teleport.

That's because we receive all the components in the default slot, with no easy way to iterate through each component and teleport them to somewhere else. Will leave this open and pinned in case later we realize that there is actually a way to use it, or if there is a pull request submitted, more ideas, etc.

@kinow kinow pinned this issue Jan 14, 2024
@kinow kinow modified the milestones: 1.2.1, 1.3.0 Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant