Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash type too inflexible #6

Open
GoogleCodeExporter opened this issue Mar 17, 2015 · 1 comment
Open

Hash type too inflexible #6

GoogleCodeExporter opened this issue Mar 17, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

The current design has the hash in the setup package stored as a plain byte 
array. I presume that the plan is to support longer hashes in the future by 
checking the length of the array, but this has one major flaw.

Presume that a SHA-3 algorithm is selected. It will likely be reccommended for 
widespread use shortly thereafter. If a subsequent flaw is found, any 
replacement chosen or tweaks applied will keep the API invariant, *including* 
the digest length. The versioning inherent in protocol buffers will not help 
because the current protocol is insufficiently self-descriptive and has 
unwarranted assumptions. I would suggest including some sort of identifier of 
which hash is in use.

Original issue reported on code.google.com by [email protected] on 6 Mar 2012 at 6:21

@GoogleCodeExporter
Copy link
Author

Another protobuf-related concern I have comes from 
http://code.google.com/apis/protocolbuffers/docs/proto.html - note their 
warnings on the use of 'required' (see 'required is forever')

Original comment by [email protected] on 6 Mar 2012 at 6:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant