Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SDRAM initialization #4307

Open
cepetr opened this issue Nov 4, 2024 · 0 comments
Open

Improve SDRAM initialization #4307

cepetr opened this issue Nov 4, 2024 · 0 comments
Labels
code Code improvements

Comments

@cepetr
Copy link
Contributor

cepetr commented Nov 4, 2024

This issue suggests a minor improvement to the SDRAM initialization code:

  1. sdram_init() function should reside in its own .c file and not be mixed with the ST BSP SDRAM driver code.
  2. sdram_init() should be called from system_init() or preferably from the SystemInit() function, rather than directly from the boardloader’s main() function.

Although this function is used only on one of the discovery kits, it introduces an unnecessary dependency and adds unnecessary complexity to the code.

@cepetr cepetr added the code Code improvements label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements
Projects
Status: No status
Development

No branches or pull requests

1 participant