-
Notifications
You must be signed in to change notification settings - Fork 1
Improve examples #17
Comments
We need to document what needs improving before this issue can be worked on |
I think it would benefit from some more real world kind of use cases, for example the graphql responses used are not actual GQL response structures but mocked to provide an example of timing differences. It would be good to provide step by step introductions to common use cases like:
and similar common scenarios we expect. The intros should provide some more fundamental understanding for users wanting to learn.. and also some result to copy and paste for users who want to be lazy 🙂 |
Examples in readme should include imports (we do for some, but definitely the first one on the page should have it too) |
I added this PR #73 which i think is a good MVP of a full example showing how to mock a request, use that mockedRequest object in a test suite and logging the mocked data from the src file. |
Hi Howard! I have only just now seen this as well as your PR - I don't seem to get notifications anymore now that I'm not in the trayio organization. Could you please outline further what examples you would like to have and how you would expect them to look like? I'm asking as I'm all for more examples but I'm not clear yet on the proposed structure in PR #73. Also, what do you mean by "nodejs test" - jest runs already on nodejs. It would be nice though having a mocha example which shows how In the readme we write:
Perhaps we could instead link to specific tests in the readme? And make it clear where the start-up phase is happening and how it's done? |
☝️ @aychtang as you might have not gotten a notification due to me not mentioning the GitHub name :) |
Oh, hey @rickschubert - hope you've been well! Think if you watch the repo (next to star + fork) you will get notifications for these PR messages. Was just a quick list I typed, not meant to be exhaustive, but basically the idea is like there should be "use case examples" for testing from say a file using stdlib of nodejs, one for express, one for react etc. I'm actually starting to think that these should live as totally separate repos which are linked to from the README, as they will have devdependencies which are not really related to So we should move that PR to |
I don't think this should live inside the @aychtang suggested about using VS Code Tours - https://marketplace.visualstudio.com/items?itemName=vsls-contrib.codetour |
The following points have been raised when the tool was being presented:
The text was updated successfully, but these errors were encountered: