Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceling/aborting streams #56

Open
vincaslt opened this issue May 8, 2020 · 3 comments
Open

Canceling/aborting streams #56

vincaslt opened this issue May 8, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@vincaslt
Copy link
Contributor

vincaslt commented May 8, 2020

Currently the transform stream reads the file streams in a loop while(true), and pipes the data to the transform stream controller as an output. There are two issues:

  1. If a file stream was aborted the error is thrown, but the transform stream doesn't get canceled.
  2. If the transform stream stream writer gets aborted, the cancelation does not get piped through to another stream.
@bencmbrook bencmbrook added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Aug 3, 2020
@bencmbrook
Copy link
Member

Hey @vincaslt do you have a test case for this? Started crafting some here #82

@eligrey
Copy link
Member

eligrey commented Sep 25, 2020

I think we should improve support for AbortController to better fix this. @bencmbrook I'll have a look at this & review your PR today

@rowanG077
Copy link

Would really like to have this. I upload zip files to and when the request files there is no way to signal to the zip transformer to stop. It just throws an error somewhere where I can't catch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants