Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Icon #50

Open
scottnath opened this issue Apr 8, 2021 · 5 comments
Open

Configurable Icon #50

scottnath opened this issue Apr 8, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@scottnath
Copy link

Hi, could the Icon please be configurable?
Right now it looks like it is pre-filled in as the photo icon.

https://github.com/tonai/storybook-addon-themes/blob/master/src/manager/ThemeSelector.tsx#L143

          <IconButton
            key="theme"
            active={selectedTheme}
            title="Change the theme of the preview"
          >
            <Icons icon="photo" />
          </IconButton>
@tonai tonai added the enhancement New feature or request label Apr 8, 2021
@fvsch
Copy link

fvsch commented Apr 16, 2021

Do you need a configurable icon, or just a default icon that is different from the one that @storybook/addon-backgrounds is using? (See the docs at https://storybook.js.org/docs/react/essentials/backgrounds and the related issue #51).

@dhruvkb
Copy link

dhruvkb commented May 6, 2021

@fvsch I think if we could just set the name of the icon (picking from this list) in the themes object under .storybook/preview.js that would resolve the issue. If that's not feasible, changing the icon to something else would also be helpful in differentiating the two addons.

Update: I forked the repo to https://github.com/dhruvkb/storybook-addon-themes and installed the fork via npm.

$ npm install dhruvkb/storybook-addon-themes#master

It's a workaround but that's all we have until the issue is resolved.

@nickofthyme
Copy link

@dhruvkb I like that solution! Would you mind creating a PR on this repo?

@dhruvkb
Copy link

dhruvkb commented Jul 13, 2021

@nickofthyme, I've opened #64 with my changes.

Update: Closed #64 because it seems that this project is unmaintained.

@RiteshMakan
Copy link

Thank you for this PR. It would be very helpful in distinguishing this add-on from the essentials background icon

@tonai tonai mentioned this issue Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants