Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests to support Django 3 and drop Django 1 and Python 2.7 #92

Open
B-T-D opened this issue Jan 31, 2020 · 1 comment

Comments

@B-T-D
Copy link

B-T-D commented Jan 31, 2020

I've created a local version of this library that passes all the included unit tests for Python 3.8, Django 3.0.2, and the long-term-support Django 2.2. But it's not compatible with Python 2 or Django 1. So if I open a pull request now, it's not going to pass the integration tests as currently configured.

I propose dropping the relevant TOX_ENVs from .travis.yml and adding new ones for Python 3.7 and 3.8, and for Django 3.0.

I think some people might now be encountering problems integrating this into Django 3.0 projects. So I think the benefit of updating for Django 3 compatibility outweighs any costs of ending Django 1 and Python 2.7 support.

@pgiki
Copy link

pgiki commented Feb 11, 2021

I managed to get to work with Python 3.6 and Django 3.1. To do so I replace line ""from django.utils.encoding import python_2_unicode_compatible""" with ""from six import python_2_unicode_compatible""" in the entire project. I use sublime text so just did find and replace it in all folders. You may use any other find and replace methods of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants