Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font size by variable, and check excerpt empty #605

Open
zkmark opened this issue Apr 22, 2024 · 0 comments
Open

Add font size by variable, and check excerpt empty #605

zkmark opened this issue Apr 22, 2024 · 0 comments
Labels
feature Features, refactoring, enhancements, improvements triage Awaiting review

Comments

@zkmark
Copy link

zkmark commented Apr 22, 2024

Description

Describe your feature request.

Add font size by variable, and check excerpt empty

References

In this part you should use a css variable
https://github.com/tomusborne/generatepress/blob/master/assets/css/all.css#L629

For example, the one that comes with WordPress by default
font-size: var(--wp--preset--font-size--normal);

Since it can't be changed from the css editor even if I use !important

--
In this part, you should ask if the_excerpt() exists, since it generates empty space when you add the excerpt value to 0

https://github.com/tomusborne/generatepress/blob/master/content.php#L69

<?php if (get_the_excerpt()): ?>
<div class="entry-summary"<?php echo $itemprop; // phpcs:ignore -- No escaping needed. ?>>
<?php the_excerpt(); ?>
</div>
<?php endif ?>
@zkmark zkmark added the feature Features, refactoring, enhancements, improvements label Apr 22, 2024
@github-actions github-actions bot added the triage Awaiting review label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features, refactoring, enhancements, improvements triage Awaiting review
Projects
None yet
Development

No branches or pull requests

1 participant