Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7.1 does not report its own version #97

Open
rperce opened this issue Apr 27, 2022 · 3 comments · May be fixed by #100
Open

v0.7.1 does not report its own version #97

rperce opened this issue Apr 27, 2022 · 3 comments · May be fixed by #100

Comments

@rperce
Copy link

rperce commented Apr 27, 2022

Replicata

╭─(robert)───(~/scratch)
╰──╼ curl -sSLO https://github.com/tomnomnom/gron/releases/download/v0.7.1/gron-linux-amd64-0.7.1.tgz
╭─(robert)───(~/scratch)
╰──╼ tar xzvf gron-linux-amd64-0.7.1.tgz
gron
╭─(robert)───(~/scratch)
╰──╼ ./gron --version
gron version dev

Expectata

gron --version should report its release number, not dev. Compare with the previous version:

╭─(robert)───(~/scratch)
╰──╼ curl -sSLO https://github.com/tomnomnom/gron/releases/download/v0.6.1/gron-linux-amd64-0.6.1.tgz
╭─(robert)───(~/scratch)
╰──╼ tar xzvf gron-linux-amd64-0.6.1.tgz
gron
╭─(robert)───(~/scratch)
╰──╼ ./gron --version
gron version 0.6.1
@dotcs
Copy link

dotcs commented May 4, 2022

The same happens for me.

Is this because the argument -ldflags "-X main.gronVersion=${VERSION}" has been removed from the release script?

badf401#diff-e3b83f8b89d67c5106cf02b79df582265e774eb93bbffb7e2ca26f05c73776dfL55

dotcs added a commit to dotcs/gron that referenced this issue May 6, 2022
@gbolo
Copy link

gbolo commented Jan 5, 2023

The same happens for me.

Is this because the argument -ldflags "-X main.gronVersion=${VERSION}" has been removed from the release script?

badf401#diff-e3b83f8b89d67c5106cf02b79df582265e774eb93bbffb7e2ca26f05c73776dfL55

yes that's the reason. I was probably a mistake. @tomnomnom ^^

@mloskot
Copy link

mloskot commented May 23, 2023

I noticed the same issue while packaging gron official Windows binaries for winget (see #109)

image

It would be helpful if the official binaries reported 0.7.1 instead of dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants