Skip to content
This repository has been archived by the owner on Dec 30, 2020. It is now read-only.

env.js issue #1

Open
dvlpr-eth opened this issue Oct 22, 2019 · 1 comment
Open

env.js issue #1

dvlpr-eth opened this issue Oct 22, 2019 · 1 comment

Comments

@dvlpr-eth
Copy link

Hey, I tried to send pull request but it seems you don't have it enabled, there is issue with env.js. const isDev is missing .env, it prevents Gulp to add sourcemap to css. Ternary operator is missing === 'production'

- export const NODE_ENV = process.env.NODE_ENV ? "production" : "development";
- export const isDev = process.NODE_ENV === "development";
+ export const NODE_ENV = process.env.NODE_ENV === 'production' ? 'production' : 'development';
+ export const isDev = process.env.NODE_ENV === 'development';
export const isProd = process.env.NODE_ENV === 'production';

@YgorNeves
Copy link

@hamidnoei do you have any idea how to add react to this boilerplate?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants