From 005b625490531c86dfcfd3fa3c171d0b2648be38 Mon Sep 17 00:00:00 2001
From: tnagorra <weathermist@gmail.com>
Date: Sun, 4 Aug 2024 12:12:58 +0545
Subject: [PATCH 1/2] Add list modifier on listToGroupList

---
 src/transform.test.ts | 37 ++++++++++++++++++++++++++----
 src/transform.ts      | 52 ++++++++++++++++++++++++++++++++++++++-----
 2 files changed, 80 insertions(+), 9 deletions(-)

diff --git a/src/transform.test.ts b/src/transform.test.ts
index 343f96f..aad68da 100644
--- a/src/transform.test.ts
+++ b/src/transform.test.ts
@@ -129,8 +129,37 @@ test('group list into map', () => {
             'shyam',
         ],
     };
-    expect(listToGroupList(input, (e) => e.id, (e) => e.name)).toEqual(outputTwo);
-    expect(
-        listToGroupList(undefined, (e: Input) => e.id, (e: Input) => e.name),
-    ).toEqual(undefined);
+    expect(listToGroupList(
+        input,
+        (e) => e.id,
+        (e) => e.name,
+    )).toEqual(outputTwo);
+
+    const outputThree = {
+        1: { key: '1', count: 3 },
+        2: { key: '2', count: 1 },
+    };
+    expect(listToGroupList(
+        input,
+        (e) => e.id,
+        (e) => e.name,
+        (ez, k) => ({ key: k, count: ez.length }),
+    )).toEqual(outputThree);
+
+    const outputFour = {
+        1: { key: '1', count: 3 },
+        2: { key: '2', count: 1 },
+    };
+    expect(listToGroupList(
+        input,
+        (e) => e.id,
+        undefined,
+        (ez, k) => ({ key: k, count: ez.length }),
+    )).toEqual(outputFour);
+
+    expect(listToGroupList(
+        undefined,
+        (e: Input) => e.id,
+        (e: Input) => e.name,
+    )).toEqual(undefined);
 });
diff --git a/src/transform.ts b/src/transform.ts
index 37e9098..39be3af 100644
--- a/src/transform.ts
+++ b/src/transform.ts
@@ -15,12 +15,17 @@ type ListModifier<T, Q, K extends OptionKey> = (
     index: number,
     acc: Q[]
 ) => Q;
-type GroupListModifier<T, Q, K extends OptionKey> = (
+type GroupItemModifier<T, Q, K extends OptionKey> = (
     element: T,
     key: K,
     index: number,
     acc: Partial<Record<K, Q[]>>
 ) => Q;
+type GroupListModifier<T, R> = (
+    elements: T[],
+    // FIXME: we need to pass key of type K
+    key: string,
+) => R;
 export type KeySelector<T, K extends OptionKey> = (element: T, index: number) => K;
 
 type NewKeySelector<T, K extends OptionKey> = (key: string, element: T) => K;
@@ -172,17 +177,42 @@ export function listToGroupList<T, K extends OptionKey>(
 export function listToGroupList<T, Q, K extends OptionKey>(
     list: T[],
     keySelector: KeySelector<T, K>,
-    modifier: GroupListModifier<T, Q, K>,
+    modifier: GroupItemModifier<T, Q, K>,
 ): Obj<Q[]>;
 export function listToGroupList<T, Q, K extends OptionKey>(
     list: Maybe<T[]>,
     keySelector: KeySelector<T, K>,
-    modifier: GroupListModifier<T, Q, K>,
+    modifier: GroupItemModifier<T, Q, K>,
 ): Obj<Q[]> | undefined;
-export function listToGroupList<T, Q, K extends OptionKey>(
+export function listToGroupList<T, Q, K extends OptionKey, R>(
+    list: T[],
+    keySelector: KeySelector<T, K>,
+    modifier: GroupItemModifier<T, Q, K>,
+    groupModifier: GroupListModifier<Q, R>,
+): Obj<R>;
+export function listToGroupList<T, Q, K extends OptionKey, R>(
     list: Maybe<T[]>,
     keySelector: KeySelector<T, K>,
-    modifier?: GroupListModifier<T, Q, K>,
+    modifier: GroupItemModifier<T, Q, K>,
+    groupModifier: GroupListModifier<Q, R>,
+): Obj<R> | undefined;
+export function listToGroupList<T, K extends OptionKey, R>(
+    list: T[],
+    keySelector: KeySelector<T, K>,
+    modifier: undefined,
+    groupModifier: GroupListModifier<T, R>,
+): Obj<R>;
+export function listToGroupList<T, K extends OptionKey, R>(
+    list: Maybe<T[]>,
+    keySelector: KeySelector<T, K>,
+    modifier: undefined,
+    groupModifier: GroupListModifier<T, R>,
+): Obj<R> | undefined;
+export function listToGroupList<T, Q, K extends OptionKey, R>(
+    list: Maybe<T[]>,
+    keySelector: KeySelector<T, K>,
+    modifier?: GroupItemModifier<T, Q, K>,
+    groupModifier?: GroupListModifier<T | Q, R>,
 ) {
     if (isNotDefined(list)) {
         return undefined;
@@ -205,5 +235,17 @@ export function listToGroupList<T, Q, K extends OptionKey>(
         },
         {},
     );
+    if (groupModifier) {
+        return Object.keys(val).reduce<Partial<Record<K, R>>>(
+            (acc, key) => {
+                const value = val[key as K];
+                if (value) {
+                    acc[key as K] = groupModifier(value, key);
+                }
+                return acc;
+            },
+            {},
+        );
+    }
     return val;
 }

From 4718f59ce67c703ac7f8f30838b9c94b413ecfb7 Mon Sep 17 00:00:00 2001
From: tnagorra <weathermist@gmail.com>
Date: Sun, 4 Aug 2024 12:13:36 +0545
Subject: [PATCH 2/2] 2.2.0

---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index b731aac..e6d4588 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@togglecorp/fujs",
-    "version": "2.1.1",
+    "version": "2.2.0",
     "description": "Friendly Utility for JS",
     "files": [
         "/build"