Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password generated in Edge is different to other implementations #8

Open
leemeichin opened this issue Oct 3, 2016 · 8 comments
Open
Assignees

Comments

@leemeichin
Copy link

Full name: Robert McTables
Master Password: correcthorsebatterystaple
Site: github.com

In Edge 14:

Password: Luzz0/CedkSowi

In Safari/Chrome + Non-web versions:

Password: QonoTosbQepv1=
@tmthrgd
Copy link
Owner

tmthrgd commented Oct 5, 2016

Can you post the output of https://tmthrgd.github.io/mpw-js/test/?

@leemeichin
Copy link
Author

Sure! It looks like there's an error with the test itself:

mpw_1

mpw_2

@tmthrgd
Copy link
Owner

tmthrgd commented Mar 26, 2017

@leemachin That error shouldn't have prevented the test suite from functioning, but either way, it has now been fixed (see #9). Would you mind running the test suite again for me?

@jmichael2497
Copy link

jmichael2497 commented Feb 5, 2019

was curious to help and check in my dual core W10-64 pro 1809 system.

MS Edge 44.17763.1.0 / EdgeHTML 18.17763 completely fails right away.
GC 72.0.3626.81 (64-bit) passes 23sec.
Fx 60.5.0esr (64-bit) passes 2min23sec.

(seems like Fx doesn't soak up the cpu power until almost the end).

@tmthrgd
Copy link
Owner

tmthrgd commented Feb 5, 2019

@jmichael2497 Thanks for the update. Is there any error message from the failure or in the debug console?

@tmthrgd
Copy link
Owner

tmthrgd commented Feb 5, 2019

@jmichael2497 (From memory): The slowdown in Firefox is caused by missing support for the right PBKDF2 algorithm which is instead done partly in JavaScript.

@jmichael2497
Copy link

@jmichael2497 Thanks for the update. Is there any error message from the failure or in the debug console?

sorry forgot to specify all test lines just end basically with similar variable timings of

"Failed; [object Object] (after 601.4000000000001ms)"

and a quick peek through the built in dev tools did not show any errors or warnings in the console.

i would generally recommend folks use a clean and locked down browser like fx or gc anyway (shrug).

@tmthrgd tmthrgd mentioned this issue Jun 11, 2019
@jmichael2497
Copy link

for reference on same dual core W10-64 pro 21H2 system:

  • MS 109.0.1518.78 passes after almost 15.0min
  • GC 109.0.5414.120 passes after almost 1.5min
  • Fx 102.7.0esr passes after almost 1.5min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants