Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory profiling (#658) #660

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Memory profiling (#658) #660

merged 2 commits into from
Oct 31, 2024

Conversation

themighty1
Copy link
Member

@themighty1 themighty1 commented Oct 31, 2024

This PR adds the correct attribution to the Memory Profiling PR

* (squashing to simplify rebase)
rebased on dev
reorganized files
fix gh workflow

* modify workflow

* update dockerfile

Co-authored-by: Valentin Mihov <[email protected]>
@themighty1 themighty1 merged commit faab999 into dev Oct 31, 2024
5 of 6 checks passed
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.48%. Comparing base (e6bc93c) to head (631a3eb).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #660   +/-   ##
=======================================
  Coverage   54.48%   54.48%           
=======================================
  Files         193      193           
  Lines       20618    20618           
=======================================
  Hits        11234    11234           
  Misses       9384     9384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@themighty1 themighty1 mentioned this pull request Oct 31, 2024
@themighty1 themighty1 deleted the commit_amend branch October 31, 2024 09:19
@valo
Copy link
Contributor

valo commented Oct 31, 2024

Thank you, folks! I really appreciate the effort <3 If you are coming to Devcon, I'll be happy to have a drink together 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants