WIP Channel Estimation #8

marenz2569 · 2023-07-02T09:40:22Z

Closes #4

…nt, but a start

…Burst Split

…link

tanneberger

See comments, but everything else looks quite good.

tanneberger · 2023-07-07T11:40:54Z

include/iq_stream_decoder.hpp

+  private:
+    void upperMacWorker();
+
+    std::complex<float> hard_decision(std::complex<float> symbol);


trailing return types.

tanneberger · 2023-07-07T11:41:17Z

include/iq_stream_decoder.hpp

+
+    const float SEQUENCE_DETECTION_THRESHOLD = 1.5;
+
+    std::shared_ptr<LowerMac> lower_mac_{};


why is this shared_ptr ?

tanneberger · 2023-07-07T11:41:25Z

include/iq_stream_decoder.hpp

+    std::shared_ptr<LowerMac> lower_mac_{};
+    std::shared_ptr<BitStreamDecoder> bit_stream_decoder_{};
+
+    bool is_uplink_{};


maybe init the value

tanneberger · 2023-07-07T11:41:39Z

include/iq_stream_decoder.hpp

+
+    bool is_uplink_{};
+
+    std::shared_ptr<StreamingOrderedOutputThreadPoolExecutor<std::vector<std::function<void()>>>> threadPool_;


the fucking name :D

tanneberger · 2023-07-07T11:42:08Z

include/streaming_ordered_output_thread_pool_executor.hpp

+#include <vector>
+
+// thread pool executing work but outputting it the order of the input
+template <typename ReturnType> class StreamingOrderedOutputThreadPoolExecutor {


just cursed

tanneberger · 2023-07-07T11:45:39Z

src/bit_stream_decoder.cpp

+    auto score_ndb_split = pattern_at_position_score(frame_, kNORMAL_TRAINING_SEQ_2, 244);
+
+    auto minimum_score = score_sb;
+    BurstType burstType = BurstType::SynchronizationBurst;


tanneberger · 2023-07-07T11:47:19Z

src/decoder.cpp

-void Decoder::process_bit(uint8_t symbol) noexcept {
-    assert(symbol <= 1);
+    if (iq_or_bit_stream_) {
+        std::complex<float>* rx_buffer_complex = reinterpret_cast<std::complex<float>*>(rx_buffer);


I think actually a static_cast is enough if u just want to change the pointer type.

tanneberger · 2023-07-07T11:48:01Z

src/iq_stream_decoder.cpp

+    , bit_stream_decoder_(bit_stream_decoder)
+    , is_uplink_(is_uplink) {
+    std::transform(training_seq_n_.crbegin(), training_seq_n_.crend(),
+                   std::back_inserter(training_seq_n_reversed_conj_), [](auto v) { return std::conj(v); });


this is nice !

tanneberger · 2023-07-07T11:48:55Z

src/iq_stream_decoder.cpp

+}
+
+void IQStreamDecoder::upperMacWorker() {
+    while (true) {


maybe we need a way to gracefully kill this. So some variable that we can toggle if we want a graceful shutdown. Like when we receive some signal

tanneberger · 2023-07-07T11:49:23Z

src/iq_stream_decoder.cpp

+    }
+}
+
+std::vector<uint8_t> IQStreamDecoder::symbols_to_bitstream(std::vector<std::complex<float>> const& stream) {


trailing return types.

tanneberger · 2023-07-18T21:31:12Z

src/examples/tetra_puncturing.cpp

+    return res;
+}
+
+auto print(std::vector<int> const& res) -> void {


pls keep it uniform const std::vector<>& or std::vector<> const&

…horter executing time.

marenz2569 added 10 commits July 2, 2023 11:38

implement argument parsing for IQ stream

8235f53

move current decoder to bit_stream_decoder

a513161

implement reading IQ and hard decision symbol mapper

9ef1196

uplink sequence burst detection

5e91c93

implement first version of synchronization of bursts. very unperforma…

fe70e99

…nt, but a start

add parsing stub for supplementary llc pdu

a99c463

fix upper mac parsing logic. add lower mac parsing for Normal Uplink …

109e26c

…Burst Split

use std::function to abstract and delay processing of upper mac in up…

ce6949a

…link

implement StreamingOrderedOutputThreadPoolExecutor

c64bdfd

remove duplicate code

00a8bd6

tanneberger requested changes Jul 7, 2023

View reviewed changes

marenz2569 added 6 commits July 9, 2023 02:37

add example for all different tetra RCPC punctering schemes

63cc74e

Use different viterbi decoder

3853c6b

add test for viterbi decoder

4a7b1e9

remove old code

ad2eade

fix memory accumalation

c87e0d8

update to newer version of viterbi decoder library. use sse4.1

0760983

tanneberger reviewed Jul 18, 2023

View reviewed changes

marenz2569 added 9 commits August 12, 2023 01:21

streaming thread pool executor wait_lok instead of lock and less threads

a8ec51c

clang-format. add pthread names

ebf0998

update flake.lock to 23.05

cb239fa

implement LLC basic link pdus with fcs

38e9308

implement a crude way to stop program on CTRL-C or EOF

31946c5

optimize conv for detection

feba058

improve performance by a bit

5c9bed1

add more performance improvements

2057a1b

Refactor lower mac coding

722a1fa

marenz2569 force-pushed the feature/channel-estimation branch from 8f029f3 to 722a1fa Compare January 28, 2024 01:48

marenz2569 added 2 commits January 28, 2024 13:44

precompute descrambling table

53830b8

fix bug in thread pool executor

643fd8b

marenz2569 added 8 commits January 29, 2024 01:21

move to raw pointers in performance critical regions

83f80cc

l2/lower_mac: use fixed size buffer for descrambler result

2d34a8e

l2/lower_mac: use fixed size buffer for reed muller 3014 result

ec9e2ef

l2/lower_mac: use fixed size buffer for deinterleaver result

10f9181

utils/bit_vector: do less copying and more unsafe pointer handling. s…

80a9b32

…horter executing time.

update debug print

e85e832

update debug print

633aa81

fix descrambling precomputation

1389d55

tanneberger merged commit 73f0bde into master Jun 2, 2024
1 check failed

marenz2569 deleted the feature/channel-estimation branch June 4, 2024 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP Channel Estimation #8

WIP Channel Estimation #8

marenz2569 commented Jul 2, 2023

tanneberger left a comment

tanneberger Jul 7, 2023

tanneberger Jul 7, 2023

tanneberger Jul 7, 2023

tanneberger Jul 7, 2023

tanneberger Jul 7, 2023

tanneberger Jul 7, 2023

tanneberger Jul 7, 2023

tanneberger Jul 7, 2023

tanneberger Jul 7, 2023

tanneberger Jul 7, 2023

tanneberger Jul 18, 2023


		const float SEQUENCE_DETECTION_THRESHOLD = 1.5;

		std::shared_ptr<LowerMac> lower_mac_{};


		bool is_uplink_{};

		std::shared_ptr<StreamingOrderedOutputThreadPoolExecutor<std::vector<std::function<void()>>>> threadPool_;

WIP Channel Estimation #8

WIP Channel Estimation #8

Conversation

marenz2569 commented Jul 2, 2023

tanneberger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment