Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asymmetric failing during Deforum Animation. #10

Open
gateway opened this issue May 12, 2023 · 7 comments
Open

Asymmetric failing during Deforum Animation. #10

gateway opened this issue May 12, 2023 · 7 comments

Comments

@gateway
Copy link

gateway commented May 12, 2023

Hi, I noticed when looking the auto1111 output that every frame was throwing a error with the asymmetric-tiling script installed.

error:

Traceback (most recent call last):
  File "E:\Stable-Diffusion\auto1111-new\modules\scripts.py", line 417, in process
    script.process(p, *script_args)
TypeError: Script.process() missing 5 required positional arguments: 'active', 'tileX', 'tileY', 'startStep', and 'stopStep'```

I'm not sure what the issue is, I talked to Deforum Dev's and they said to reach out to you guys.  Ideally it would be awesome to use this in deforum as well.

Thank you for all your hard work!
@tjm35
Copy link
Owner

tjm35 commented May 17, 2023

Hi,

I can't reproduce this with auto1111 version a9fed7c and deforum-for-auto1111 version 54ed8f8; using the default options for Deforum and enabling "Active" in Asymmetric tiling (on the txt2img tab) correctly produces a video that tiles in the X axis, with no errors in the output.

Could you let me know what versions of auto1111 and deforum-for-auto1111 you're having problems with?

Thanks.

@gateway
Copy link
Author

gateway commented May 18, 2023

Hi,

I can't reproduce this with auto1111 version a9fed7c and deforum-for-auto1111 version 54ed8f8; using the default options for Deforum and enabling "Active" in Asymmetric tiling (on the txt2img tab) correctly produces a video that tiles in the X axis, with no errors in the output.

Could you let me know what versions of auto1111 and deforum-for-auto1111 you're having problems with?

Thanks.

Sorry for the late reply..

So It happens when you enable control net, I was using depth (im trying to create 360 videos)..
I was hoping the x tiling would work but I also dont see the Asymmetric options in deforum just tiling which doesnt work :(

So set something to 2d or 3d , enable control net.. Im using 1.1.x with 1.1 models..

image

The I would love to have x or y tiling options in deforum, with 360 photos its important to have those on the x so their is no visible seam..

image

Also completely separate and I can create a issue for it, but same thing trying to create 360 panos which works fine in img2img, but when I want to upscale them lets say using ultimate upscaler and 2x size the tile x doesnt seem to work ..

Cheers!!!

@gateway
Copy link
Author

gateway commented May 23, 2023

any thoughts?

@tjm35
Copy link
Owner

tjm35 commented May 26, 2023

I'm not in a position to test deforum-with-controlnet myself right now, but I can suggest the following:

  • If the controlnet source image/video doesn't tile, it will be continually forcing the generated image to not tile. In particular the source image needs to tile after the controlnet preprocessing has happened. I'd suggest running just the preprocessor (with "Preview Annotator Result") and making sure the output of that tiles correctly, then using that as the source in ControlNet with no preprocessor.
  • As I said in the last comment, Deforum will use whatever settings are set on Asymmetric Tiling in the txt2img or img2img tabs (depending on the type of generation you're doing), so make sure you have those set the way you want them.

For upscaling, many upscalers don't respect tiling; that's just up to the upscaler, not something an unrelated plugin can affect. The comments on this issue might be of interest, though?

@herhu
Copy link

herhu commented Jun 2, 2023

is a way to add this values in the defoum_settings.json ? that case with one are the values ? any idea ?

@gateway
Copy link
Author

gateway commented Aug 2, 2023

I'm not in a position to test deforum-with-controlnet myself right now, but I can suggest the following:

  • If the controlnet source image/video doesn't tile, it will be continually forcing the generated image to not tile. In particular the source image needs to tile after the controlnet preprocessing has happened. I'd suggest running just the preprocessor (with "Preview Annotator Result") and making sure the output of that tiles correctly, then using that as the source in ControlNet with no preprocessor.
  • As I said in the last comment, Deforum will use whatever settings are set on Asymmetric Tiling in the txt2img or img2img tabs (depending on the type of generation you're doing), so make sure you have those set the way you want them.

For upscaling, many upscalers don't respect tiling; that's just up to the upscaler, not something an unrelated plugin can affect. The comments on this issue might be of interest, though?

Hey sorry for the super late reply, was traveling for the past 2 months, and im finally back to this because I need to do a 360 video with deforum but with the proper amazing tilling working.

I have attached the basic deform default + 1 CN enabled with an image so if you test this make sure to go to the CN tab, and change the image path, cant be a url.. once this is enabled this throws deform off, if their are no CN's applied it works fine. So even if im not using the plugin for a video it also throws my CN's and fails which is an issue because I then have to delete the extension, do my video and when i need to tile put the folder back in etc..

so i guess if it cant tile it should not cause deforum to fail if someone uses the a CN in deforum, or better yet it actually tiles :)

in the main defrom you can load settings from the file below, or just go to the default deforum, cn table, enable one, add an image path..

image

thoughts?

image

20230802105239_settings.txt

@gateway
Copy link
Author

gateway commented Oct 15, 2023

any chance to fix this, I could help fund the time you spend on it. let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants