Skip to content
This repository has been archived by the owner on Jul 31, 2018. It is now read-only.

<noscript data-reactid=".0"></noscript> #54

Closed
wieringen opened this issue Feb 4, 2016 · 7 comments · May be fixed by #55
Closed

<noscript data-reactid=".0"></noscript> #54

wieringen opened this issue Feb 4, 2016 · 7 comments · May be fixed by #55

Comments

@wieringen
Copy link

I am trying to create a production build but after I run 'npm run build' and open the static dir on localhost in my browser. I see a blank index page with these elements.

<div id="root"><noscript data-reactid=".0"></noscript></div>

What am I doing wrong?

@tj
Copy link
Owner

tj commented Feb 4, 2016

no clue :D I haven't done any prod builds yet so that part might not be ideal

@firsara
Copy link

firsara commented Feb 4, 2016

@wieringen as far as I've tested this now it works fine as long as you're index.html is in the root.
i.e. if you're going to say http://localhost:3000/static/ it will output <noscript[...
in such cases either set a tag in index.html or adjust the main Route in index.js before building:

<Route path="/" component={App}>

@tj maybe an environment based config?

@tj
Copy link
Owner

tj commented Feb 4, 2016

hmmm I don't think it would ever not be root for me personally

@firsara
Copy link

firsara commented Feb 4, 2016

well for me neither but it would at least fix this issue.
anyways i think having a split up local and remote configuration in general wouldn't be that bad for a boilerplate.

@tj
Copy link
Owner

tj commented Feb 4, 2016

true true, might use it for feature flags or something. in general I'm trying to keep it to a minimal set of things I actually use. I'll come back to it if I end up using some flags :D

@firsara
Copy link

firsara commented Feb 4, 2016

sure, that's totally understandable. it kinda needs to stay a boilerplate, not a framework, right (or planning on something bigger)? ;)
Although I would not mind about that one single config file. but it's your repo so feel free to drop it

@tj
Copy link
Owner

tj commented Feb 4, 2016

yep just boiler for now, definitely not attempting to make it work for everyone, that's what I found most boilers were so I wanted something a bit cleaner that wasn't trying to cater to everyone's needs

@tj tj closed this as completed Feb 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants