-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support postgresql v11-16 #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.
It does; tests have been updated to cover v16 installation. I would note that the currently queued-up tests may not pass because they are based on the |
Hi @BrennanColberg, the test are based on the changes you’ve made, so I wouldn’t worry too much about that. |
Co-authored-by: Tonye Jack <[email protected]>
Co-authored-by: Tonye Jack <[email protected]>
Co-authored-by: Tonye Jack <[email protected]>
@all-contributors please add @BrennanColberg for code, docs and test |
I've put up a pull request to add @BrennanColberg! 🎉 |
PostgreSQL v16 was publicly released this last September, but this action (and therefore by extension tj-actions/pg-dump) hard-caps users to installing v15 at the highest.
This PR modernizes that limitation, allowing users to install postgresql v16.
It also causes the tests to stop installing postgresql v10 (though it still allows for users to specify v10 for backward-compatibility purposes), because the homebrew-based installation tests on macOS now fail when attempting to install v10, with this message:
I believe this change should prompt a new version release, or at least a re-release of v2, so that other actions (like tj-actions/pg-dump) can be updated to work with v16 properly.