Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support postgresql v11-16 #15

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Conversation

BrennanColberg
Copy link
Contributor

@BrennanColberg BrennanColberg commented Nov 22, 2023

PostgreSQL v16 was publicly released this last September, but this action (and therefore by extension tj-actions/pg-dump) hard-caps users to installing v15 at the highest.

This PR modernizes that limitation, allowing users to install postgresql v16.

It also causes the tests to stop installing postgresql v10 (though it still allows for users to specify v10 for backward-compatibility purposes), because the homebrew-based installation tests on macOS now fail when attempting to install v10, with this message:

Error: postgresql@10 has been disabled because it is not supported upstream!

I believe this change should prompt a new version release, or at least a re-release of v2, so that other actions (like tj-actions/pg-dump) can be updated to work with v16 properly.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.

@BrennanColberg
Copy link
Contributor Author

BrennanColberg commented Nov 22, 2023

Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.

It does; tests have been updated to cover v16 installation. I would note that the currently queued-up tests may not pass because they are based on the main branch checks and include the matrix entry of (macos-latest, 10). All installations of v10 on macOS in checks are failing nowadays, even on a clean fork of this repository, because Homebrew appears to see something wrong with the package.

entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@jackton1
Copy link
Member

Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.

It does; tests have been updated to cover v16 installation. I would note that the currently queued-up tests may not pass because they are based on the main branch checks and include the matrix entry of (macos-latest, 10). All installations of v10 on macOS in checks are failing nowadays, even on a clean fork of this repository, because Homebrew appears to see something wrong with the package.

Hi @BrennanColberg, the test are based on the changes you’ve made, so I wouldn’t worry too much about that.

@BrennanColberg BrennanColberg changed the title support postgresql v16, stop testing postgresql v10 support postgresql v11-16 Nov 28, 2023
@jackton1 jackton1 added the merge when passing Merge the PR automatically once all status checks have passed label Nov 29, 2023
@jackton1
Copy link
Member

@all-contributors please add @BrennanColberg for code, docs and test

Copy link
Contributor

@jackton1

I've put up a pull request to add @BrennanColberg! 🎉

@jackton1 jackton1 merged commit 85c3755 into tj-actions:main Nov 29, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when passing Merge the PR automatically once all status checks have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants