Drop login options / gatekeeper/ Heroku? #198
Replies: 10 comments 3 replies
-
A potential stopgap solution could be to use Render which is a similar service to Heroku. It offers 750 free usage hours a month and doesn't require a credit card to sign up. I managed to set it up pretty easily for my test instance of JKAN. You basically just plug in the link to the Gatekeeper repo and tell Render what commands to use to build and run the app. This is what I'm considering using instead of Heroku for our JKAN instance on opendata.scot |
Beta Was this translation helpful? Give feedback.
-
Render won't work for my use case (and how long will free last, see Heroku..) - although it does seem pretty neat. Gatekeeper maintenance doesn't seem active which might be a bigger issue. My plan would be to switch to:
Does a Markdown workflow block any of your users? |
Beta Was this translation helpful? Give feedback.
-
Out of interest, what is your use case? To be honest, we don't really used the front-end editing that much unless we're onboarding new contributors to the project who want to get started with something simple like updating organization details. All our dataset pages are generated by a python script as part of our dataset pipeline so we don't really use the editors for those. In short, removing the editor front-end and editing raw markdown files shouldn't block our users. We already have an "Open in GitHub" button on our org and dataset pages like the one you described and they work well for jumping from the page to the source behind it. You can see examples here: |
Beta Was this translation helpful? Give feedback.
-
We just don't want to have any external services as dependencies for this project. Our use cases is migrating https://www.opendataphilly.org/ form CKAN to JKAN. +1 on no blockers for dropping front-end editing. Awesome re:Open in GitHub, will bring the edit in Github bits into JKAN first. |
Beta Was this translation helpful? Give feedback.
-
Tried to go and remove it but the intermediate steps were easier: #196 #195 In my testing so far dropping the login/inline editing capabilities could reduce the size of Javascript by more then 50% I meant to ping earlier, but wanted to know if this change would affect any of you (and if so, how): @pezholio @keeganmcbride @JJediny @tursics @amercader @lxyu0405 @tobinbradley @wilsaj @davidread @dracos While I'm pinging all previous contributors, I wanted to ask if you want to be more involved in JKAN upstream - I can ask you for reviews or we can try to pick up some older PRs. |
Beta Was this translation helpful? Give feedback.
-
I'm happy to help pick up some of the JKAN upstream stuff. Please feel free to tag me in PRs or request review @BryanQuigley @timwis |
Beta Was this translation helpful? Give feedback.
-
Oh my goodness...I setup some email filters to hide a subset of GitHub notifications, and apparently made them too eager, because I completely missed the ones from this repo this month! 🙈 Awfully sorry about that. Funny enough, I was knee-deep in this two weeks ago, too! I realised that authentication on I first tried migrating it to vercel, which I've used plenty of times for Node.js apps, and failed miserably. They seem to expect the function to be in the Will write up my thoughts on the wider question of auth/editing shortly and post here. |
Beta Was this translation helpful? Give feedback.
-
As a sidenote whilst we're on the topic of the getting started process with JKAN. I had wondered whether it's worth changing the setup process from forking to setting up the upstream repository as a template repository instead? Given that we'll all have different datasets and orgs we're hosting, I didn't really see a scenario in which forking makes sense for contributing upstream from our own JKAN instances? Whilst I've not looked in detail, if I understand template repos correctly, I think it's still possible to pull downstream changes from the original template into your instance if you wanted to pull in new changes and bug fixes? This was a short article I found on the topic https://medium.com/geekculture/how-to-use-git-to-downstream-changes-from-a-template-9f0de9347cc2 |
Beta Was this translation helpful? Give feedback.
-
Hey @JackGilmore that's a really interesting idea. @BryanQuigley also mentioned on our call a few weeks ago the idea of potentially pulling in JKAN as a gem (lots of new possibilities are open now that we could potentially switch to using GitHub Actions to build JKAN instead of the built-in jekyll builder). Would you mind posting a new discussion topic about that? |
Beta Was this translation helpful? Give feedback.
-
I've given this some thought since our chat, @BryanQuigley. Given that:
I'd agree that it makes sense to decouple the editing UI from the core of JKAN. I'd suggest we continue to offer an editing UI, but have it be opt-in. The nice thing about having the site's database sit in a public github repo is we can just have a completely separate application point at it, and the user-facing presentation application is none-the-wiser. (EDIT: although Netlify CMS may provide a nice middle ground here) This would also let JKAN remain a purely static site, hosted for free, and contain the server-side stuff to the optional editing UI journey. As I've been thinking about this, though, I've come to a number of crossroads in my mind, and realised that it may be helpful to make the projects guiding principles more explicit (and surface some areas where they're not entirely defined). I'll post those separately for discussion. EDIT: Just had another idea.. might be a bit out there, but we could run a central jkan editing instance, which any org can use to update their jkan site. Of course they could also run the editing instance themselves, but for those who want to skip the faff of hosting, this could be quite simple. |
Beta Was this translation helpful? Give feedback.
-
This would involve deleting the admin page, the add-dataset, add-organization, dropping the ability to login.
If this changed would affect your org -please let us know!
Beta Was this translation helpful? Give feedback.
All reactions