Merge pull request #119 from tim-hub/retire-unmatching-outgoing-links

clean up the outgoing links
tim-hub · Aug 30, 2023 · 41b593b · 41b593b
2 parents 02be4ed + 3847a9c
commit 41b593b
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 51 deletions.
diff --git a/src/data/constants.ts b/src/data/constants.ts
@@ -19,8 +19,6 @@ export interface BibleReferencePluginSettings {
   bibleTagging?: boolean
   bookTagging?: boolean
   chapterTagging?: boolean
-  bookBacklinking?: boolean // this is refering to outgoing link
-  chapterBacklinking?: boolean // this is refering to outgoing link
 
   // add this to ui at some point todo
   enableBibleVerseLookupRibbon?: boolean
@@ -35,8 +33,6 @@ export const DEFAULT_SETTINGS: BibleReferencePluginSettings = {
   bibleTagging: false,
   bookTagging: false,
   chapterTagging: false,
-  bookBacklinking: false,
-  chapterBacklinking: false,
   enableBibleVerseLookupRibbon: false,
 }
 

diff --git a/src/ui/BibleReferenceSettingTab.ts b/src/ui/BibleReferenceSettingTab.ts
@@ -207,34 +207,6 @@ export class BibleReferenceSettingTab extends PluginSettingTab {
       )
   }
 
-  setUpBookOutgoingLinking = (containerEl: HTMLElement): void => {
-    new Setting(containerEl)
-      .setName('Add a Book Outgoing Link')
-      .setDesc('Makes an outgoing link for the book, for example [[John]]')
-      .addToggle((toggle) =>
-        toggle
-          .setValue(!!this.plugin.settings?.bookBacklinking)
-          .onChange((value) => {
-            this.plugin.settings.bookBacklinking = value
-            this.plugin.saveData(this.plugin.settings)
-          })
-      )
-  }
-
-  setUpChapterOutgoingLinking = (containerEl: HTMLElement): void => {
-    new Setting(containerEl)
-      .setName('Add a Chapter Outgoing Links')
-      .setDesc('Makes an outgoing link for the chaper, for example [[John1]] ')
-      .addToggle((toggle) =>
-        toggle
-          .setValue(!!this.plugin.settings?.chapterBacklinking)
-          .onChange((value) => {
-            this.plugin.settings.chapterBacklinking = value
-            this.plugin.saveData(this.plugin.settings)
-          })
-      )
-  }
-
   async display(): Promise<void> {
     const {containerEl} = this
     containerEl.empty()
@@ -261,9 +233,6 @@ export class BibleReferenceSettingTab extends PluginSettingTab {
     this.setUpBibleTagging(containerEl)
     this.setUpBookTagging(containerEl)
     this.setUpChapterTagging(containerEl)
-    // todo retire the bottom two settings
-    this.setUpBookOutgoingLinking(containerEl)
-    this.setUpChapterOutgoingLinking(containerEl)
 
     if (flags.isFeatureEnabled('vod')) {
       // todo add vod settings and reflect feature flags

diff --git a/src/verse/VerseSuggesting.ts b/src/verse/VerseSuggesting.ts
@@ -38,22 +38,6 @@ export class VerseSuggesting
     this.bibleVersion = settings.bibleVersion
   }
 
-  public get head(): string {
-    let head = super.head
-    // backlinks and tags use the BibleReferenceHeader
-    //  and regex to clean book and chapters that will match
-    //  across multiple different search queires
-    if (this.settings?.bookBacklinking) {
-      head += ` [[${this.verseReference.bookName}]]`
-    }
-    if (this.settings?.chapterBacklinking) {
-      head += ` [[${
-        this.verseReference.bookName + this.verseReference.chapterNumber
-      }]]`
-    }
-    return head
-  }
-
   public get bottom(): string {
     let bottom = super.bottom
     if (