-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colour data for hiking routes #1546
Comments
We already pass thru the way |
Hi @nvkelso, thanks for respoding so quickly. Yes, it is on hiking route relation. Here in Slovakia hiking routes are mapped really well. They have also assigned colour data in hiking routes relations. Here is one example: https://www.openstreetmap.org/relation/571351#map=14/48.1719/17.1185. |
Hi @nvkelso do you have some news regarding this? I could work on this a bit, but I just needs some hints. If I understand correctly vector-datasource is using some jinja templates to prepare data for tileserver? Could this to get it working just mean editing or creating new jinja templates? |
Are there some functions in vector-datasource to add properties from relations into roads? I can work on this. |
I'm a little rusty on this, but I think the place to start is with
It currently fetches the vector-datasource/data/functions.sql Lines 120 to 141 in 1c26f35
The output from that (now a 4-tuple instead of a 3-tuple) eventually ends up in vector-datasource/vectordatasource/transform.py Line 7643 in 1c26f35
Where you'd need to fix the unpacking code to handle 4 elements. There's another function, vector-datasource/vectordatasource/transform.py Line 7952 in 1c26f35
Hope that helps! |
Thank you a lot for these hints. I will play with this. I will also need osmc:symbol tag, but I have noticed that some roads are parts of multiple relations. Will this also be handled by this modification, or should I modify something else? When it will be done, could it be merged into this repository? Or isn't this something you want? |
The The system is designed to output a single "most important" route/network info for each element, but also an array of the full values (prefixed with The way we've handled this for road networks is to have a system for describing the symbols (a.k.a. road shields) as text, which the client can then use to fetch the correct image. This is modelled on the OSM I can't speak for whether it's wanted in the repository, that's something @nvkelso would be able to say. I think it's something that could be useful for the Walkabout outdoor style for sure. |
Yes, @rwrx please submit a PR to this repo, addition of |
Hello @zerebubuth and @nvkelso I am currently working on this. I got working On this page https://github.com/tilezen/vector-datasource/blob/6e057196694b7896862c8bc2786389ad5b083f0e/docs/layers.md I can see that: "Note that these properties will not be present on MVT format tiles, as we cannot currently encode lists as values.". Is it possible to add support for encode lists as values? Maybe comma separated? Or add something like |
I have created pull request here: #2091 |
Is it somehow possible to get colour data for hiking routes - https://wiki.openstreetmap.org/wiki/Tag:route=hiking ? I assume that they are stripped during data retrieval. If they are stripped is it somehow possible to not strip this colour data information?
The text was updated successfully, but these errors were encountered: