Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle vector-datasource config files with package #6

Open
rmarianski opened this issue Jun 5, 2017 · 0 comments
Open

Bundle vector-datasource config files with package #6

rmarianski opened this issue Jun 5, 2017 · 0 comments

Comments

@rmarianski
Copy link
Member

I think that we can get away with not forcing a checkout of vector-datasource. The config assets we need from there, which looks to be the queries yaml and jinja files currently, can just be bundled with the package itself. And when we need to read these on startup, we can simply expect it to be in a relative location from the vector-datasource package itself. Or we can just take a dotted name for the vector datasource package to support extensions.

This should simplify the installation instructions, our deployment automation, and some of our configuration.

IIRC the history here is that we didn't always have vector-datasource as a package, because there didn't used to be code there. But now that we do we shouldn't need to have to check it out separately.

@rmarianski rmarianski self-assigned this Jun 5, 2017
@nvkelso nvkelso transferred this issue from another repository Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant