Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evicting slow stores may trigger redundant scheduling #8895

Open
mayjiang0203 opened this issue Dec 11, 2024 · 2 comments · May be fixed by #8912
Open

Evicting slow stores may trigger redundant scheduling #8895

mayjiang0203 opened this issue Dec 11, 2024 · 2 comments · May be fixed by #8912
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. report/customer Customers have encountered this bug. type/enhancement The issue or PR belongs to an enhancement.

Comments

@mayjiang0203
Copy link

Enhancement Task

There are many redundant scheduling after evict-slow-store has been triaggered.

Image

Image

Image
@mayjiang0203 mayjiang0203 added the type/enhancement The issue or PR belongs to an enhancement. label Dec 11, 2024
@lhy1024
Copy link
Contributor

lhy1024 commented Dec 11, 2024

Because we select target for evict leader from follower randomly, the cluster is not even and need to balance leader again.
Maybe we should sort store according to the num of leader rather than random.
But I am not sure whether it will affect performance.

pd/pkg/schedule/schedulers/evict_leader.go

Line 365 in fbfcdb8

target := candidates.RandomPick()

@lhy1024 lhy1024 linked a pull request Dec 12, 2024 that will close this issue
Open
@seiya-annie
Copy link

/report customer

@ti-chi-bot ti-chi-bot bot added report/customer Customers have encountered this bug. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. report/customer Customers have encountered this bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scheduler: consider leader score when evict leader lhy1024/pd
3 participants
@mayjiang0203 @lhy1024 @seiya-annie