Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading monitors #8867

Open
okJiang opened this issue Dec 4, 2024 · 1 comment
Open

Misleading monitors #8867

okJiang opened this issue Dec 4, 2024 · 1 comment
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@okJiang
Copy link
Member

okJiang commented Dec 4, 2024

Bug Report

Image
Image

They cannot be matched to each other because the former is incorrectly multiplied by 60, resulting in all values being 60 times the original.

pd/metrics/grafana/pd.json

Line 2678 in 3cfd66f

"expr": "sum(rate(pd_schedule_operators_count{k8s_cluster=\"$k8s_cluster\", tidb_cluster=\"$tidb_cluster\", event=\"create\"}[1m])*60) by (type)",

What did you do?

What did you expect to see?

Don't multiply 60

What did you see instead?

What version of PD are you using (pd-server -V)?
@okJiang okJiang added the type/bug The issue is confirmed as a bug. label Dec 4, 2024
@okJiang
Copy link
Member Author

okJiang commented Dec 19, 2024 •
edited
Loading

The numerical discrepancy is due to the rule checker's unit being incorrect; it should be xx/s.

https://github.com/tikv/pd/blame/c5812ee79fe5090145f6be2d7b3fe73e75d95905/metrics/grafana/pd.json#L7971

How about unifying them to xxxx/s? @rleungx @JmPotato @lhy1024

@okJiang okJiang changed the title The monitors are wrong Misleading monitors Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jebter @okJiang