Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Prompt to used saved keystore info during build #908

Open
newportsolutionsgroup opened this issue Dec 2, 2021 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@newportsolutionsgroup
Copy link

newportsolutionsgroup commented Dec 2, 2021

We use the same Android.keystore file for multiple apps.
When doing a build I was prompted for the keystore and chose the keystore I had used a week before for another app.
After being prompted for the password the build is fired off.
This doesn't give me the opportunity to specify which APP in the keystore I am using.
The build completed with what I am assuming the wrong keystore information (app name from last week that is stored in extension settings).
I had to delete the stored settings.

I propose when doing an Android build, after selecting the .keystore file, the extension prompts the user with "Use Last Saved Keystore Information?" (Yes/No). Alternatively, the build process could still prompt for the keystore alias but at that point we are entering almost everything again. Alternative #2, the extension could prompt during build "Use saved keystore information for ${<Alias Name>} ?"

It took me a couple builds to see in the bottom right corner a notification that saved keystore information was being used and a button to delete the saved information.

@newportsolutionsgroup newportsolutionsgroup added the enhancement New feature or request label Dec 2, 2021
@ewanharris
Copy link
Collaborator

@newportsolutionsgroup I'm not sure I'm understanding "This doesn't give me the opportunity to specify which APP in the keystore I am using.", the information used/saved for a keystore is the alias, location, password, and privateKeyPassword.

My understanding is that if a keystore is shared between apps then this information is the same between apps as the information is for the keycstore itself and not the application. If the information was invalid (say alias=foo was provided but alias=bar is correct) then the Titanium build would error as it wouldn't be able to sign the application using that keystore as it is invalid.

Is my understanding incorrect/incomplete? Doing some research it seems like a keystore can contain multiple keypairs that can be identified by the alias argument? That makes storing the keystore information a bit more complex as we currently use the keystore path as a key for the information (including alias) so I think that would need completely reworking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants