resize_window has no effect on save_and_open_screenshot with qt5

[ZoharLiran]

Similar to
#354

I am seeing a similar issue as @datapimp on the same configuration:
Mavericks using Homebrew
qt4 resize_window affects save_and_open_screenshot
qt5 resize_window won't affect save_and_open_screenshot

Any ideas around this since #354 was closed by @jferris ?

[brondavies]

👍

[russellsanders]

👍

[msyesyan]

👍

[cderong]

👍

[jferris]

I'll try to revisit this during the 2.0 release. It should be easier then, as we'll no longer have Qt 4 in the mix and we can remove a large amount of support code for deprecated functionality.

[Szarko]

👍

[voltechs]

Looking forward to that! Can't figure out why my screenshots are so small. :(

[lucascaton]

Any news on this one?

[eschersgirl]

+1

[HannesBenson]

👍

[paveltyk]

👍

[whitslar]

Just ran into this. For now I'm monkeypatching Capybara:

module Capybara
  class Session

    def save_screenshot(path = nil, options = {})
      options[:width] = current_window.size[0] unless options[:width]
      options[:height] = current_window.size[1] unless options[:height]

      path = prepare_path(path, 'png')
      driver.save_screenshot(path, options)
      path
    end

  end
end

[andrewculver]

@whitslar This monkey patch worked perfectly for us. Thanks!

[sfate]

There is no need to monkey patch capybara.

Here is an instruction from capybara-screenshot readme:

Capybara-webkit defaults to a screenshot size of 1000px by 10px. To specify a custom size, use the following option:

Capybara::Screenshot.webkit_options = { width: 1024, height: 768 }

This issue can be closed AFAIU.