Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong category meta title #10

Open
yaniv14 opened this issue Dec 11, 2021 · 0 comments
Open

wrong category meta title #10

yaniv14 opened this issue Dec 11, 2021 · 0 comments
Labels

Comments

@yaniv14
Copy link

yaniv14 commented Dec 11, 2021

blocklayered/blocklayered.php

Lines 3208 to 3226 in fc53434

$category_title = (empty($category->meta_title[$id_lang]) ? $category->name[$id_lang] : $category->meta_title[$id_lang]);
$category_metas = Meta::getMetaTags($id_lang, 'category');
$title = '';
$keywords = '';
if (is_array($filter_block['title_values'])) {
foreach ($filter_block['title_values'] as $key => $val) {
$title .= ' > '.$key.' '.implode('/', $val);
$keywords .= $key.' '.implode('/', $val).', ';
}
}
$title = $category_title.$title;
if (!empty($title)) {
$smarty->assign('meta_title', $title.' - '.Configuration::get('PS_SHOP_NAME'));
} else {
$smarty->assign('meta_title', $category_metas['meta_title']);
}

based on this logic, $category_metas will never be used, and in case Meta:getCategoryMetas is override it will not be considered at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants