Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vimeo Scraper: interactionStatistic can be missing #225

Closed
Spone opened this issue Oct 25, 2023 · 2 comments · Fixed by #226
Closed

Vimeo Scraper: interactionStatistic can be missing #225

Spone opened this issue Oct 25, 2023 · 2 comments · Fixed by #226

Comments

@Spone
Copy link
Contributor

Spone commented Oct 25, 2023

Here is an example of a video that does not have interactionStatistic in the application/ld+json <script> tag.

https://vimeo.com/7848846

It causes the following error:

NoMethodError: undefined method `find' for nil:NilClass

        interaction_statistic.find do |stat|
                             ^^^^^
@markets
Copy link
Collaborator

markets commented Oct 26, 2023

Hey @Spone

Would you mind sending a fix? 🙏🏼

@Spone Spone mentioned this issue Oct 26, 2023
Merged
@Spone
Copy link
Contributor Author

Spone commented Oct 26, 2023

Hi @markets, here is my PR: #226, but I can't figure out how to fix the failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add safe navigation for user_interaction_count Spone/video_info
2 participants
@Spone @markets