New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightbox improvements #31

Open

2 of 4 tasks

thekid opened this issue Nov 2, 2022 · 0 comments

Labels

enhancement help wanted

Owner

thekid commented Nov 2, 2022 •

edited

Loading

Use https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog
Update JavaScript to use <dialog open> instead of <div id="lightbox" class="open">
Prevent background scrolling - see https://getbootstrap.com/docs/4.3/components/modal/ and https://usefulangle.com/post/279/hide-page-scrollbar-when-fixed-modal-opened
Prevent layout shifts when hiding the scrollbar (adjust padding as seen here)

The text was updated successfully, but these errors were encountered:

thekid added help wanted good first issue labels

thekid mentioned this issue

Change lightbox to use HTML <dialog> element #41

Merged

2 tasks

thekid removed help wanted good first issue labels

thekid changed the title ~~Implement lightbox with HTML dialog~~ Lightbox improvements

thekid added enhancement help wanted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment