From c44d62b81f0bac50932eab9f5fd873b73ae40570 Mon Sep 17 00:00:00 2001 From: Sam Menza Date: Fri, 28 Feb 2020 17:10:33 -0800 Subject: [PATCH] bug: Updated browserVersion and version to behave the same - When version is set to 'insider preview' and browserName is 'MicrosoftEdge', the driver name should be 'MicrosoftEdgeChromium --- src/core/lib/executors/Node.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/core/lib/executors/Node.ts b/src/core/lib/executors/Node.ts index 1093c4798..0774462b4 100644 --- a/src/core/lib/executors/Node.ts +++ b/src/core/lib/executors/Node.ts @@ -919,12 +919,14 @@ export default class Node extends Executor { ) { driverNames.add(browserName); } else if (browserName === 'MicrosoftEdge') { - const { browserVersion } = env; + const { browserVersion, version } = env; if ( (!isNaN(browserVersion) && Number(browserVersion) < 1000) || + (!isNaN(version) && Number(version) < 1000) || // 'insider preview' may be used to specify Edge Chromium before it is // official released - (isNaN(browserVersion) && browserVersion === 'insider preview') + (isNaN(browserVersion) && browserVersion === 'insider preview') || + (isNaN(version) && version === 'insider preview') ) { driverNames.add('MicrosoftEdgeChromium'); } else {