-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asyncio support #257
Comments
Gosh. I'm not sure. @EvanKrall what do you think? |
I'd be in favor, and would probably work on the PR to Yelp/paasta to use it. Fortunately, it doesn't look like any of the model objects are doing any lazy fetching of data, so the model objects' API should be able to stay the same, and it looks like just a separate |
I'm interested to see how you test the async version. Ideally we'd have mostly the same set of tests for both async and non-async. In general, I care less about DRY in test code than non-test code, so if you end up having to copy-paste-sed the tests, that's fine, but ideally we'd enforce test parity between the two versions somehow. |
Great!! I'll keep in mind the test suite during the development of |
btw, the current |
It looks like we're testing against py2.7 and py3.3: travis calls I'd be okay with bumping the python3 version requirement to 3.6; I don't think I can speak with the same authority for python 2.7 - I don't know how many python 2.7 users use this library. Would it be onerous to put the async client in a different module so that python 2.7 users can still use the requests-based client? |
Currently marathon-python depends has a
MarathonClient
that depends onrequests
. Would you accept anAsyncMarathonClient
version that usesaiohttp
? I would gladly submit a PRThe text was updated successfully, but these errors were encountered: