Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client's 'get_info' fails due to unexpected keyword argument in Marathon 1.5.2 #235

Open
zonnie opened this issue Dec 8, 2017 · 1 comment

Comments

@zonnie
Copy link

zonnie commented Dec 8, 2017

I'm getting the following when querying info:

  File "/usr/local/lib/python2.7/dist-packages/marathon/client.py", line 698, in get_info
    if force:
  File "/usr/local/lib/python2.7/dist-packages/marathon/client.py", line 65, in _parse_response
  File "/usr/local/lib/python2.7/dist-packages/marathon/models/base.py", line 43, in from_json
    return cls(**{to_snake_case(k): v for k, v in attributes.items()})
  File "/usr/local/lib/python2.7/dist-packages/marathon/models/info.py", line 41, in __init__
    else MarathonConfig().from_json(marathon_config)
  File "/usr/local/lib/python2.7/dist-packages/marathon/models/base.py", line 43, in from_json
    return cls(**{to_snake_case(k): v for k, v in attributes.items()})
TypeError: __init__() got an unexpected keyword argument 'revive_offers_repetitions'

I'm using marathon-python 0.9.3 and Marathon 1.5.2

@tanderegg
Copy link
Contributor

I've experienced this error as well when I upgraded from Marathon 1.4.8 to 1.4.9, likely the inclusion of "revive_offers_repetitions" into the JSON was considered a bug fix since that command-line flag has been around for a while. I've tested a fix in my fork, and can open a PR next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants