Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In MarathonApp initialization, ip_address input argument is not referenced #200

Open
taha27 opened this issue Jun 5, 2017 · 4 comments
Open

Comments

@taha27
Copy link

taha27 commented Jun 5, 2017

An ip_address variable is accepted as an input argument for the MarathonApp.__init__ method but never actually used. We need this for our deployment usecase as we want to use Calico network profiles for network isolation. I would be more than happy to submit a pull request after a short conversation to understand the exact points of interface. Thanks in advance.

@taha27 taha27 changed the title In MarathonApp initialization, ip_address is not referenced In MarathonApp initialization, ip_address input argument is not referenced Jun 5, 2017
@solarkennedy
Copy link
Contributor

Huh.

Are we just missing a self.ip_address = ip_address to make it an attribute uses can use?

@taha27
Copy link
Author

taha27 commented Jun 5, 2017

@solarkennedy That and a class definition for a MarathonIpAddress object. Similar to what's done in the task.py script I presume

@solarkennedy
Copy link
Contributor

shipit, make the PR that fits your needs and I'll merge it in.

@taha27
Copy link
Author

taha27 commented Jun 7, 2017

Thanks. The company I work at requires me to go through an approval process before I can contribute to open source projects. Doing that now and will send in a PR once that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants