Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll until WinAppDriver is ready instead of sleeping for a fixed amount of time #96

Open
tristanlabelle opened this issue Sep 12, 2023 · 0 comments
Open

Poll until WinAppDriver is ready instead of sleeping for a fixed amount of time #96

tristanlabelle opened this issue Sep 12, 2023 · 0 comments

Comments

@tristanlabelle
Copy link
Contributor

tristanlabelle commented Sep 12, 2023 •
edited
Loading

Currently we use a hard-coded 1 second sleep for both of these:

Polling can shorten the waiting time and will let us assert if the expected transition does not happen within some expected time.
@tristanlabelle tristanlabelle mentioned this issue Sep 13, 2023
Merged
@tristanlabelle tristanlabelle changed the title Use retryUntil to poll until WinAppDriver is ready/terminated Poll until WinAppDriver is ready instead of sleeping for a fixed amount of time Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tristanlabelle