Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should examples use something other than hostname? #7

Open
djMax opened this issue Jun 17, 2017 · 1 comment
Open

Should examples use something other than hostname? #7

djMax opened this issue Jun 17, 2017 · 1 comment

Comments

@djMax
Copy link
Collaborator

djMax commented Jun 17, 2017

If I understand correctly, using hostname() as the lock id would mean that multiple execution paths on the same host could both own the lock. This is bad (typically) right? It should be somehow operation-specific, like a guid or something.
@thebigredgeek
Copy link
Owner

Yeah probably. Feel free to update the README with a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djMax @thebigredgeek