Bootstrap 5.3 #264
Closed
Bootstrap 5.3 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading to Bootstrap 5.3.2 because it has a dark mode.
Refactoring to address breaking change in [utilities](https://getbootstrap.com/docs/5.3/migration/#utilities-3).
Refactoring to address breaking change change in [badges](https://getbootstrap.com/docs/5.3/migration/#badges). Removing second `@extend` because `.badge-secondary` has become `.badge .bg-secondary` so the one `@extend` should apply to it.
Refactoring to address breaking change in [Sass](https://getbootstrap.com/docs/5.3/migration/#sass). Removing the only use of a deprecated mixin; hover.
Refactoring to address breaking change in [close button](https://getbootstrap.com/docs/5.3/migration/#close-button-1).
Refactoring to address breaking change in [utilities](https://getbootstrap.com/docs/5.3/migration/#utilities-3).
Re-compiling the SCSS files with sass after addressing all breaking changes listed in https://getbootstrap.com/docs/5.3/migration/ that are applicable to this skin's use of Bootstrap.
|
I also noticed icons inside buttons (mainly from the Page Form extension) look like this on the master branch using Bootstrap 4; there are barely noticeable minus and plus signs there. So on this branch, I've replaced them with their fa-icon equivalents. Whilst fixing that, I've given the non-saving buttons a style similar to how they are on the Vector skin by making them extend Plain edit page
Form creation page
Example edit with form page (two text areas)
|
- Extending .btn-outline-* classes so the buttons like preview, show, changes etc. look similar to how they are on the Vector skin. - Applying font-awesome styles to the icons inside the buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262
Upgrading to 5.3 and addressing breaking changes according to the migration guide.