Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

Better SpotifyWebComponent #4

Open
tgiachi opened this issue Jul 26, 2019 · 6 comments
Open

Better SpotifyWebComponent #4

tgiachi opened this issue Jul 26, 2019 · 6 comments
Assignees
Labels
components Components related enhancement New feature or request

Comments

@tgiachi
Copy link
Owner

tgiachi commented Jul 26, 2019

In this moment, spotify can query devices and current playing song.

The characteristic features of:

  • Query songs
  • Playing song on device
  • Parse input commands (example send_command("PLAY_SONG", "artist - song", device_name) )
@tgiachi tgiachi added enhancement New feature or request components Components related labels Jul 26, 2019
@bkardol
Copy link
Collaborator

bkardol commented Aug 2, 2019

So we probably want to support most player functionality, am I right?:
Spotify API - Player

Done so far:

  • SET_VOLUME - Set volume on current or specified device. (was already there)
  • PAUSE - Pauses playing on current device.
  • PLAY_TRACK - Play a track on current or specified device.
  • PLAY_CONTEXT - Play an artist/album/playlist on current or specified device.
  • RESUME - Resume playing on current or specified device.

What's left:

  • NEXT - Skip to next track.
  • PREVIOUS - Skip to previous track.
  • SET_REPEAT - Set repeat mode.
  • SET_SHUFFLE - Set shuffle mode.

If I'm missing something, please let me know.

@tgiachi
Copy link
Owner Author

tgiachi commented Aug 2, 2019

Hi @bkardol, Yes is correct! I also think the possibility of searching for songs is useful, What do you think about it?

Thank you!

@bkardol
Copy link
Collaborator

bkardol commented Aug 2, 2019

@tgiachi , good one, I will include search functionality aswell.

Thanks for the quick reply!

@bkardol
Copy link
Collaborator

bkardol commented Aug 6, 2019

Regarding the search functionality:
Should it be implemented with a command that puts its result in an event?
Or should it be returned immediately from the command. If this is the case I think we need some adjustments in the EventBridge and DispatcherService.

Thanks!

@tgiachi
Copy link
Owner Author

tgiachi commented Aug 6, 2019

Hi @bkardol !
In my last commit (on master branch) i've added on SendCommand object result. Please try if works! Have a nice day

@bkardol
Copy link
Collaborator

bkardol commented Aug 6, 2019

Nice, I'll try it out. Thanks @tgiachi !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
components Components related enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants