Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp units incorrect for new Inside Temp and Outside Temp #135

Closed
aneisch opened this issue Jan 2, 2025 · 2 comments
Closed

Temp units incorrect for new Inside Temp and Outside Temp #135

aneisch opened this issue Jan 2, 2025 · 2 comments

Comments

@aneisch
Copy link

aneisch commented Jan 2, 2025

@iainbullock when running the :dev image from iain-dev the if statement at https://github.com/tesla-local-control/tesla_ble_mqtt_core/blob/iain-dev/mqtt-discovery-sensors.sh#L231 is not needed and causes issues with Home Assistant. HA will automatically convert the units. The temperature can be sent as °C and so long as the unit_of_measurement reflects that, HA will auto convert to the user's unit settings. The same goes for the tyre pressure sensor which is working as expected. (HA converts automatically to PSI for me)

With the if (incorrect):
Screen Shot 2025-01-02 at 12 54 53 PM

Without (correct):
Screen Shot 2025-01-02 at 12 55 35 PM

@iainbullock
Copy link
Contributor

iainbullock commented Jan 3, 2025

Many thanks for the feedback. I will amend for the next dev release

Please can you share the code for what you changed?

What did you set $TEMPERATURE_UNIT_FAHRENHEIT to?

Thanks

@iainbullock
Copy link
Contributor

I made a mod but it didn't make it in time for the production release v0.3.0. I have now included it in the latest dev release (v0.3.1a-dev) which is available on DockerHub as iainbullock/tesla_ble_mqtt:dev, or from GitHub as the #iain-dev branch

If you have time to test to see if it resolves the issue I'd be most grateful

Thanks

iainbullock added a commit that referenced this issue Jan 5, 2025
#135 Temp units + new sensors. iain-dev->stage
@aneisch aneisch closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants