Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate redundant boolean options on elasticsearch_index_selector into multi-value option #15

Open
jsnoble opened this issue Sep 20, 2018 · 0 comments

Comments

@jsnoble
Copy link
Member

jsnoble commented Sep 20, 2018

There are options on the the elasticsearch_index_selector operator that I think are mutually exclusive, these include:

delete
upsert
create
update
Could these be replaced with a single operation option that allows the user to select one of the values?

https://github.com/terascope/teraslice/blob/master/docs/reference.md#elasticsearch_index_selector

@godber
Member
godber commented on May 3, 2017
This doesn't really matter much but might resolve some ambiguities in the code.

@kstaken
Member
kstaken commented on May 4, 2017
Yes this would probably help.

@kstaken kstaken added the priority:medium label on Aug 23, 2017
@kstaken
Member
kstaken commented on Aug 23, 2017
This is a big breaking change but gets into the over complication of this particular processor. The processor likely needs to be refactored and broken up to reduce this complexity. The existing processor can be deprecated but kept around until all jobs have been converted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant