Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project review by Majda Misini Ignjatovic #3

Open
majdateokem opened this issue Jan 9, 2019 · 0 comments
Open

Project review by Majda Misini Ignjatovic #3

majdateokem opened this issue Jan 9, 2019 · 0 comments

Comments

@majdateokem
Copy link

Hi Albertas,

Please find my review of your project based on requirements on the course page.

First, thank you for a very tidy notebook. Everything was clear and I had no problems running the notebook on my computer.

I my opinion this notebook meets the project requirements.

  1. The notebook is well documented, with clear instructions on how to run it.

  2. The code used to read, write and manipulate data, works perfectly and is well documented.

  3. The notebook contains nice looking plots, each with a title and properly labeled axes. I especially like the interactive plot.

  4. Figures are sufficiently large, with the right resolution.

  5. The notebook is archived in a repository with a digital object (DOI).

I found one typo. A letter is missing in the text below figure 4:
we have a graphical cmparison which can be inspected visually
should be
we have a graphical comparison which can be inspected visually.

Overall, this is a really good project. It is well written, organised, and easy to follow and reproduce.

Good luck with all your future projects!
Best,
Majda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant