Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded files are empty with uploadFromStream #60

Open
benschlegel opened this issue May 9, 2024 · 0 comments
Open

Uploaded files are empty with uploadFromStream #60

benschlegel opened this issue May 9, 2024 · 0 comments

Comments

@benschlegel
Copy link

I'm trying to upload a file using client.uploadFromStream by doing something like this:

if (exists(currPath) && isFile(currPath)) {
  const fileStream = createReadStream(currPath)
  .on('data', (chunk) => {
    // logging for stream progress here
  })

  // Upload file from stream
  await client.uploadFromStream(`${nextcloud_path}/${fileName}`, fileStream);
}

This does not throw an error and creates a file at the correct location on nextcloud, but the file is 0 Bytes/empty. If I write out the stream to a buffer, it correctly reads the data.

If i use client.put instead, everything works as expected, but then you lose the benefits of using the stream in the first place. Changing the example to the following works as expected and writes the actual content to the file on nextcloud.

if (exists(currPath) && isFile(currPath)) {
  // Stream for reading in file
  const bufs = [];
  const fileStream = createReadStream(currPath)
    .on('data', (chunk) => {
      bufs.push(chunk);
    })
    .on('end', async () => {
      const fileBuffer = Buffer.concat(bufs);
      await client.put(`${nextcloud_path}/${fileName}`, fileBuffer);
    }); 
}

This leads me to believe that uploadFromStream is not working as I would expect it to.

I have docker set up through TrueNAS, I don't think upload limits are the problem
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant