Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFX 1.16.0 Issue #7733

Open
vkarampudi opened this issue Dec 12, 2024 · 3 comments
Open

TFX 1.16.0 Issue #7733

vkarampudi opened this issue Dec 12, 2024 · 3 comments
Labels

Comments

@vkarampudi
Copy link
Contributor

Please comment or link any issues you find with TFX 1.16.0.

@pritamdodeja
Copy link
Contributor

In TFX 1.15.1, I could use

model.save(fn_args.serving_model_dir, save_format='tf', signatures=signatures)

and the model would work as expected in tensorflow serving. Given that keras3 has deprecated the SavedModel format as per https://keras.io/guides/serialization_and_saving/, specifically, "The only supported format in Keras 3 is the "Keras v3" format, which uses the .keras extension.",

The use of

tf.saved_model.save(model, export_dir=fn_args.serving_model_dir, signatures=signatures)

does not work as expected in tensorflow serving. What is the right way to store the model such that it can served?

Secondly, does the solution for the above also solve it for the InfraValidator component?

@surajk998
Copy link

surajk998 commented Dec 27, 2024

Hi Team,
I am currently working on upgrading the tfx library from 1.15.0 to 1.16.0 but I am facing these recurring issues with the kubeflow v2 APIs.

here, in 1.16.0
I have observed that we are storing the runtime parameters via attach_parameter method ( https://github.com/tensorflow/tfx/blob/v1.16.0/tfx/orchestration/kubeflow/v2/parameter_utils.py#L56 ) in parameter_utils module which has a dependency on ParameterContext class ( https://github.com/tensorflow/tfx/blob/v1.16.0/tfx/orchestration/kubeflow/v2/parameter_utils.py#L22 )
image

and in the PipelineBuilder class of pipeline_builder.py module,
for the exit handler StepBuilder, we have not used it inside the ParameterContext scope.
https://github.com/tensorflow/tfx/blob/master/tfx/orchestration/kubeflow/v2/pipeline_builder.py#L258

@pritamdodeja
Copy link
Contributor

In TFX 1.15.1, I could use

model.save(fn_args.serving_model_dir, save_format='tf', signatures=signatures)

and the model would work as expected in tensorflow serving. Given that keras3 has deprecated the SavedModel format as per https://keras.io/guides/serialization_and_saving/, specifically, "The only supported format in Keras 3 is the "Keras v3" format, which uses the .keras extension.",

The use of

tf.saved_model.save(model, export_dir=fn_args.serving_model_dir, signatures=signatures)

does not work as expected in tensorflow serving. What is the right way to store the model such that it can served?

Secondly, does the solution for the above also solve it for the InfraValidator component?

Hello, can you please advise about this, as soon I'll have to use the path foundation model released by Google, and that model uses the latest version of XLA/Tensorflow, and this SavedModel thing would be a blocker for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants