Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize auth error handling #406

Closed
4 tasks
nightsh opened this issue Jan 8, 2018 · 5 comments
Closed
4 tasks

Standardize auth error handling #406

nightsh opened this issue Jan 8, 2018 · 5 comments
Assignees
@nightsh
Labels
2 - Working <= 5 blocked Defense Elvis in progress
Milestone
User accounts

Comments

@nightsh
Copy link
Member

nightsh commented Jan 8, 2018 •
edited
Loading

  • register
  • login
  • confirm
  • recover

When errors are being sent from the server, use either the notifications service, or inline form errors, but make sure it's the same everywhere. We are allowed to make exceptions for displaying authentication errors to align with other widely used usability guidelines, but we must be consistent.
@nightsh nightsh self-assigned this Jan 8, 2018
@nightsh nightsh added this to the User accounts milestone Jan 8, 2018
@georgiana-b
Copy link
Member

Pls also make them pretty like in the designs.

@georgiana-b georgiana-b mentioned this issue Mar 12, 2018
Open
@nightsh nightsh mentioned this issue Apr 3, 2018
Merged
@ghost ghost added to review and removed in progress labels Apr 3, 2018
@georgiana-b georgiana-b mentioned this issue Mar 9, 2019
Closed
@nightsh
Copy link
Member Author

nightsh commented Mar 16, 2019

Blocked by #474

@zufanka
Copy link
Member

zufanka commented Aug 9, 2019

auth form has been redesigned. Is this sitll an issue @nightsh ?

@zufanka
Copy link
Member

zufanka commented Mar 29, 2020

@nightsh update pls!

@nightsh
Copy link
Member Author

nightsh commented Mar 30, 2020

Closing this, no auth errors detected except one that we have created a dedicated issue for: #513

@nightsh nightsh closed this as completed Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nightsh nightsh

Labels
2 - Working <= 5 blocked Defense Elvis in progress
Projects
None yet
Milestone
User accounts
Development

No branches or pull requests
3 participants
@nightsh @zufanka @georgiana-b