Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: Clarify why the the setup mentions two different version of postgres to be used #179

Open
palash25 opened this issue Oct 31, 2024 · 3 comments

Comments

@palash25
Copy link
Contributor

I am assuming it is a typo but i just want to confirm this so I am creating an issue instead of a PR

The Apply configurations sections of the contributing guide asks to apply configurations to postgres version 15 <your-editor> ~/.pgrx/data-15/postgresql.conf

but when you run make setup the configurations are applied to version 17 which is hardcoded in the Makefile.

Is this is a mistake? the apply configurations step should either mention 17 as the postgres version or not mention any version at all and leave it up to the user. Thoughts?

@ChuckHend
Copy link
Member

The guide could use more clarification. Pgrx let's us develop on multiple versions of postgres, but the default version in Cargo.toml is pg17. So those paths will change depending on which version you are trying to work on.

@palash25
Copy link
Contributor Author

i think it would be better to have something like ~/.pgrx/data-<pg-version>/postgresql.conf but its upto you. feel free to close the issue if you think otherwise.

@ChuckHend
Copy link
Member

~/.pgrx/data-<pg-version>/postgresql.conf sounds good to me for the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants