Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported CFML Engines/Versions #93

Open
jamiejackson opened this issue May 27, 2016 · 4 comments
Open

Supported CFML Engines/Versions #93

jamiejackson opened this issue May 27, 2016 · 4 comments
Assignees

Comments

@jamiejackson
Copy link
Contributor

When submitting pull requests, which CFML engines/versions should we consider?

@ddspringle
Copy link
Member

I'll have to get Cameron (the current maintainer of ValidateThis) to confirm, but my gut says Lucee 4.5+ and CF10+ are safe bets.

@cameroncf
Copy link

I'd attempt to test against whatever you have available. In a perfect world we would setup some automated tests that would find both the low and high end of supported version. For Lucee I would definitely test against 4.5. Lucee 5.0 as well if you have it available. L5 broke something In FW/1 recently so it would be worthwhile not to assume "it will just work".

Having said all of that, I think I'll take whatever help you are able to give since I've been so busy lately and have been a pretty poor maintainer of this library so far.

@jamiejackson
Copy link
Contributor Author

I'd been testing in ACF10 and L4.5, but when I tested on ACF9, I had to rework some syntax to get things to work in the older engine. Although I maintained this backward compatibility, it was at the sake of some style.

What I'm getting at is that we may want to consider drawing new lines in the sand every once in a while (and explicitly state the supported engines/versions), so that we're not always forced to write for engines that get more and more irrelevant.

@ddspringle
Copy link
Member

@jamiejackson @cameroncf I've dropped official support for ACF below v10 in all my open source projects. I'm tempted now that CF2016 is out to drop support for ACF10 as well so I can use more member functions in my FOSS code... but I'd definitely consider drawing the line at ACF10 now - perhaps create a CF < 10 branch of VT so those still running older versions can use that (unsupported) branch, and start a new 10+ branch going forward. My 2 cents on the topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants